Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for default v prefix with semver policy #385

Merged
merged 1 commit into from
May 30, 2023
Merged

Add tests for default v prefix with semver policy #385

merged 1 commit into from
May 30, 2023

Conversation

rustycl0ck
Copy link
Contributor

Add test cases to verify that semver policy with v prefix works as expected.

This is because the comparison library supports default v prefix in semver1, so this controller should too:

Optionally work with a v prefix

Footnotes

  1. https://github.com/Masterminds/semver#semver ↩

@rustycl0ck
Add tests for default v prefix with semver policy
8946d55 
Signed-off-by: rustyclock <rustyclock@protonmail.com>
@rustycl0ck rustycl0ck marked this pull request as ready for review May 30, 2023 09:25
darkowlzz
darkowlzz approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very useful tests to have. Thanks.

@darkowlzz darkowlzz merged commit 653a6de into fluxcd:main May 30, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkowlzz darkowlzz darkowlzz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rustycl0ck @darkowlzz