Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate manifests when generating kustomization.yaml #143

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Validate manifests when generating kustomization.yaml #143

merged 1 commit into from
Oct 15, 2020

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Oct 15, 2020 •
edited

Changes:

  • take into account only .yaml and .yml files when creating the resource list for the kustomization.yaml file
  • validate that yaml files are Kubernetes objects and stop the reconciliation if the validation fails

Fix: #142

@stefanprodan
Validate manifests when generating kustomization.yaml
ec0c43d 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan added the area/kustomize Kustomize related issues and pull requests label Oct 15, 2020
@stefanprodan stefanprodan merged commit e1c7fb1 into main Oct 15, 2020
@stefanprodan stefanprodan deleted the yaml-validation branch October 15, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
area/kustomize Kustomize related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Malformed YAMLs are silently removed
2 participants
@stefanprodan @hiddeco