Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use annotation helpers #152

Merged
merged 3 commits into from
Oct 22, 2020
Merged

Use annotation helpers #152

merged 3 commits into from
Oct 22, 2020

Conversation

squaremo
Copy link
Member

@squaremo
Use reconcile request annotation helpers
b8d7132 
Per fluxcd/pkg#39
@squaremo
Factor out requestReconciliation
e78726f 
There were two of these methods, identical aside from the receiver --
and the requirement on the receiver was just that it was a client that
knows the Kustomization type.
@squaremo squaremo mentioned this pull request Oct 22, 2020
Closed
5 tasks
@squaremo
Cross-reference anything from apis/meta to godoc
3ca1bf2 
This means ReconcileRequestStatus is also given a link to the godoc,
as a consolation for not having its field inlined.
stefanprodan
stefanprodan approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @squaremo

@stefanprodan stefanprodan merged commit 423dc68 into main Oct 22, 2020
@stefanprodan stefanprodan deleted the use-annotation-helpers branch October 22, 2020 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@squaremo @stefanprodan