Move dedicated watchers to in-controller watches #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
watch-in-controller
branch
6 times, most recently
from
8c0a1c0
to
7707379
Compare
This prevents the resources from getting annotated, and instead uses the `handler.EnqueueRequestsFromMapFunc` to queue requests based on changes to the source objects. Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
force-pushed
the
watch-in-controller
branch
from
7707379
to
2b86162
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the resources from getting annotated, and instead uses
the
handler.EnqueueRequestsFromMapFuncto queue requests based onchanges to the source objects.