Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor apply error reporting #205

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Refactor apply error reporting #205

merged 1 commit into from
Dec 14, 2020

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Dec 14, 2020 •
edited

Changes:

  • filter kubectl apply output and extract errors
  • limit apply output to 20K charts (avoid reaching max etcd size)
  • log kubectl exit code when the process is killed

Fix: #167
Fix: #190
Fix: #202
Fix: #203

hiddeco
hiddeco reviewed Dec 14, 2020
View reviewed changes
controllers/utils.go Outdated Show resolved Hide resolved
@stefanprodan
Refactor apply error reporting
d65ea71 
- filter kubectl apply output and extract errors
- limit apply output to 20K charts (avoid reaching max etcd size)
- log kubectl exit code when the process is killed

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan merged commit 45c0809 into main Dec 14, 2020
@stefanprodan stefanprodan deleted the filter-apply-errors branch December 14, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@stefanprodan @hiddeco