Make Path field optional and add safe guards for relative paths #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
approved these changes
Dec 16, 2020
hiddeco
force-pushed
the
safe-rel-path
branch
2 times, most recently
from
6ab7466
to
753d0a2
Compare
This commit ensures that relative (user configurable) paths never traverse outside their working directory. It does _not_ provide protection against path traversal within `kustomization.yaml` files. Signed-off-by: Hidde Beydals <hello@hidde.co>
As due to secure joins, the requirement on both providing a path and/or requiring it to be in a certain format offers little value over the UX experience of not having to provide it when you just want to reconcile whatever can be found in the root of the source reference. Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
force-pushed
the
safe-rel-path
branch
from
753d0a2
to
69a7e75
Compare
hiddeco
changed the title
Instead of using the name of the secret, as this can cause unexpected collisions in edge case scenarios. Signed-off-by: Hidde Beydals <hello@hidde.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures that relative (user configurable) paths never
traverse outside their working directory.
It does not provide protection against path traversal within
kustomization.yamlfiles.