No longer treat dirs as kustomization files #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes fluxcd#223 Signed-off-by: Michał Flendrich <michal@flendrich.pro>
stefanprodan
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #223
Signed-off-by: Michał Flendrich michal@flendrich.pro
Before this PR, kustomize-controller (incorrectly) takes a directory named
Kustomizationas a kustomization file, with the following consequences:Kustomizationis erroneously omitted from processingKustomizationdirectory as a file results in an error, reported by kustomization-controllerAfter this PR, when traversing the filesystem tree looking for Kustomization files, kustomization-controller doesn't try to take directories as kustomization files.
Testing: I believe that this change deserves an e2e test case, but apparently, in the current shape of e2e tests, this requires a GitHub repository with a "malicious" directory called Kustomization. I'll happily accept maintainers' guidance as to possible ways to test this change.