Look for all accepted Kustomization filenames #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
accept-all-kustomization-filenames
branch
from
c187f9d
to
787ea83
Compare
hiddeco
force-pushed
the
accept-all-kustomization-filenames
branch
2 times, most recently
from
1ca958c
to
7ffe184
Compare
hiddeco
force-pushed
the
accept-all-kustomization-filenames
branch
2 times, most recently
from
9ba4daa
to
b104619
Compare
Before this commit we only checked if a `kustomization.yaml` existed at the root of the given directory, this caused problems when people for example used `.yml` as the extension, as the generated `kustomization.yaml` would conflict with the `.yml` file. After this commit all recognized Kustomization filenames as listed by Kustomize itself are accepted, including files _without_ an extension (`Kustomization`). Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
force-pushed
the
accept-all-kustomization-filenames
branch
from
b104619
to
59c24e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #225
Before this commit we only checked if a
kustomization.yamlexisted atthe root of the given directory, this caused problems when people for
example used
.ymlas the extension, as the generatedkustomization.yamlwould conflict with the.ymlfile.After this commit all recognized Kustomization filenames as listed by
Kustomize itself are accepted, including files without an extension
(
Kustomization).