Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracting validation error from apply dry run output #280

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

laszlocph
Copy link
Contributor

@laszlocph laszlocph commented Feb 18, 2021

An attempt to treat validation error output the same way as apply output: reducing the noise by only returning the validation error.

Fixes: #277

Note: I'm not sure about the BDD framework used in the project. Let me know if I misuse it

@stefanprodan stefanprodan added the enhancement New feature or request label Feb 18, 2021
@laszlocph
Copy link
Contributor Author

Okay, the suite failed as even for the Utils Suite it started a k8s and was doing stuff. I will revisit this later unless you have some pointers how to go with tests. I'm happy to just write a plain golang test without the framework.

@stefanprodan
Copy link
Member

@laszlocph writing a test with go stdlib is ok.

@laszlocph
Copy link
Contributor Author

@laszlocph writing a test with go stdlib is ok.

thanks, I'm done with my changes.

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @laszlocph can you please squash all commits.

Signed-off-by: Laszlo Fogas <laszlo@laszlo.cloud>
@stefanprodan stefanprodan merged commit 064e536 into fluxcd:main Feb 22, 2021
@laszlocph laszlocph deleted the filter-validation-errors branch February 22, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to control verbosity of validation errors
2 participants