Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set leader election deadline to 30s #303

Merged
merged 2 commits into from
Mar 25, 2021
Merged

Set leader election deadline to 30s #303

merged 2 commits into from
Mar 25, 2021
+35 −31

Conversation

stefanprodan
Copy link
Member

This PR allows fine tuning the leader election with cmd args:

--enable-leader-election=true
--leader-election-release-on-cancel=true
--leader-election-lease-duration=35s
--leader-election-renew-deadline=30s
--leader-election-retry-period=5s

To make the leader election more tolerant to transient Kubernetes API outages, the renewal deadline was increased from 10s to 30s and the retry interval was bumped to 5 seconds.

Part of: fluxcd/pkg#94

@stefanprodan
Set leader election deadline to 30s
43c05a7 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan added the enhancement New feature or request label Mar 25, 2021
@stefanprodan
Use controller name in LeaderElectionID
ca1760b 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan merged commit 041b270 into main Mar 25, 2021
@stefanprodan stefanprodan deleted the le-config branch March 25, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stefanprodan @hiddeco