Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document behaviour when changes are made to fields not stored in git #501

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

somtochiama
Copy link
Member

@somtochiama somtochiama commented Nov 23, 2021

Closes fluxcd/flux2#2099

Signed-off-by: Somtochi Onyekwere somtochionyekwere@gmail.com

@@ -344,6 +344,11 @@ Note that when the `kustomize.toolkit.fluxcd.io/reconcile` annotation is set to
the controller will no longer apply changes from source, nor will it prune the resource.
To resume reconciliation, set the annotation to `enabled` or remove it.

Note:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be "Note that due to...."

@@ -344,6 +344,11 @@ Note that when the `kustomize.toolkit.fluxcd.io/reconcile` annotation is set to
the controller will no longer apply changes from source, nor will it prune the resource.
To resume reconciliation, set the annotation to `enabled` or remove it.

Note:
Due to the way kubernetes server-side apply works, the kustomize-controller can only revert
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Due to the way kubernetes server-side apply works, the kustomize-controller can only revert
Due to the way [Kubernetes server-side apply](https://kubernetes.io/docs/reference/using-api/server-side-apply/) works, the kustomize-controller can only revert

@stefanprodan stefanprodan added the area/docs Documentation related issues and pull requests label Nov 25, 2021
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
@stefanprodan stefanprodan merged commit 284b637 into fluxcd:main Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kustomization not removing attributes added by kubectl edit
2 participants