Add test for varsub in secret #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
stefanprodan
requested changes
Nov 26, 2021
| @@ -756,6 +756,18 @@ spec: | |||
| name: cluster-secret-vars | |||
| ``` | |||
|
|
|||
| Note that for substituting variables in a secret, `spec.stringData` field must be used i.e | |||
| ```yaml | |||
There was a problem hiding this comment.
Add new line above this please.
makkes
approved these changes
Nov 26, 2021
|
@makkes I see that you've approved this PR, but the doc formatting is wrong, it will not render on fluxcd.io due to that empty line missing. |
Yeah, my usual way in these situations is to approve the PR and assume that prior change requests are properly addressed, assuming the PR can't be merged with pending change requests. Does that sound reasonable? |
Yeap all good |
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
stefanprodan
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #502
Fixes: #504
Signed-off-by: Somtochi Onyekwere somtochionyekwere@gmail.com