Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update development documentation #540

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Update development documentation #540

merged 1 commit into from
Jan 19, 2022

Conversation

yiannistri
Copy link
Contributor

Fixes #468

@yiannistri
Copy link
Contributor Author

I noticed that make deploy deploys the source-controller as well (same in helm-controller). I'm aware of the dependency but people may find this surprising. Is this something that we should call out in the docs?

@stefanprodan stefanprodan added the area/docs Documentation related issues and pull requests label Jan 19, 2022
@stefanprodan
Copy link
Member

source-controller and its CRDs are a requirement for running KC/HC on a cluster, we could call it out in docs.

@yiannistri
Copy link
Contributor Author

Ok let me add a note for this.

@yiannistri
Update dev docs
7648733 
Signed-off-by: Yiannis <yiannis.triantafyllopoulos@gmail.com>
@stefanprodan stefanprodan merged commit 91e96a2 into fluxcd:main Jan 19, 2022
@yiannistri yiannistri deleted the dev-docs branch January 19, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
area/docs Documentation related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review/extend DEVELOPMENT documentation
2 participants
@yiannistri @stefanprodan