Ensure object are finalized under impersonation #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the service account used for impersonation has been deleted, skip pruning, log the error and continue with finalization to allow tenants removals from clusters. Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
hiddeco
reviewed
Jan 31, 2022
| @@ -953,6 +952,11 @@ func (r *KustomizationReconciler) finalize(ctx context.Context, kustomization ku | |||
| if changeSet != nil && len(changeSet.Entries) > 0 { | |||
| r.event(ctx, kustomization, kustomization.Status.LastAppliedRevision, events.EventSeverityInfo, changeSet.String(), nil) | |||
| } | |||
| } else { | |||
| // when the account to impersonate is gone, log the stale objects and continue with the finalization | |||
| msg := fmt.Sprintf("unable to prune objects: \n%s", ssa.FmtUnstructuredList(objects)) | |||
There was a problem hiding this comment.
Do we want the logged message to contain a newline and/or full list of objects?
There was a problem hiding this comment.
I haven't changed to log format in this PR. Each object is logged a new line like before, this makes it pretty in Slack and others.
There was a problem hiding this comment.
Yes, I get this is pretty for Slack. Was more wondering how useful it is in controller log output.
There was a problem hiding this comment.
All objects lists/actions are logged like this in KC. If you think we should use a different formatting for logs, please open an issue.
hiddeco
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the service account used for impersonation has been deleted, skip pruning, log the error and continue with finalization to allow tenants removals from clusters.
Followup: #550