Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generator: recover from kustomize build panics #637

Merged
merged 2 commits into from
Apr 27, 2022
Merged

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Apr 27, 2022

Kustomize tends to panic in unpredicted ways due to (accidental) invalid object data; recover when this happens to ensure continuity of operations.

stefanprodan and others added 2 commits April 27, 2022 12:58
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Signed-off-by: Hidde Beydals <hello@hidde.co>
@hiddeco hiddeco added enhancement New feature or request area/kustomize Kustomize related issues and pull requests labels Apr 27, 2022
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @hiddeco

@hiddeco hiddeco merged commit bcfd424 into main Apr 27, 2022
@hiddeco hiddeco deleted the fix-build-panics branch April 27, 2022 10:26
@hiddeco hiddeco added this to the GA milestone Apr 28, 2022
@stefanprodan stefanprodan modified the milestones: GA, Bootstrap GA Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kustomize Kustomize related issues and pull requests enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants