Disallow remote bases usage in Kustomize overlays #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
added
enhancement
hiddeco
reviewed
Apr 27, 2022
Add an optional flag for disabling remote bases. While the `--no-remote-bases` is set to `false` by default, Flux users are encouraged to enable it on production system for security and performance reasons. Using Kustomize remote bases means that kustomize-controller must clone the remote repositories on every reconciliation instead of using the source-controller artifacts cache. Allowing remote bases on multi-tenant clusters, means platform admins have no control over which repositories make up the desired state. Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
force-pushed
the
no-remote-bases
branch
from
2fb1596
to
cafbe25
Compare
hiddeco
approved these changes
Apr 27, 2022
makkes
reviewed
Apr 27, 2022
pjbgf
reviewed
Apr 27, 2022
takirala
added a commit
to mesosphere/kommander-applications
that referenced
this pull request
Jun 2, 2022
kustomize-controller 0.25.0+ introduced a flag to support remote kustomization overlays by default. We don't use remote bases for kustomizations (yet!) so we can safely disable it (as per recommendation upstream). See fluxcd/kustomize-controller#638 Signed-off-by: Tarun Gupta Akirala <takirala@users.noreply.github.com>
takirala
added a commit
to mesosphere/kommander-applications
that referenced
this pull request
Jun 8, 2022
kustomize-controller 0.25.0+ introduced a flag to support remote kustomization overlays by default. We don't use remote bases for kustomizations (yet!) so we can safely disable it (as per recommendation upstream). See fluxcd/kustomize-controller#638 Signed-off-by: Tarun Gupta Akirala <takirala@users.noreply.github.com>
takirala
added a commit
to mesosphere/kommander-applications
that referenced
this pull request
Jun 9, 2022
* feat: disable remote bases in kustomize overlays kustomize-controller 0.25.0+ introduced a flag to support remote kustomization overlays by default. We don't use remote bases for kustomizations (yet!) so we can safely disable it (as per recommendation upstream). See fluxcd/kustomize-controller#638 Signed-off-by: Tarun Gupta Akirala <takirala@users.noreply.github.com> * feat: Upgrade flux to 0.31.0 Co-authored-by: Tarun Gupta Akirala <takirala@users.noreply.github.com> Co-authored-by: CI <ci@mesosphere.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an optional flag for disabling Kustomize remote bases.
While the
--no-remote-basesis set tofalseby default, Flux users are encouraged to enable it on production system for security and performance reasons. Using Kustomize remote bases means that kustomize-controller must clone the remote repositories on every reconciliation instead of using the source-controller artifacts cache. Allowing remote bases on multi-tenant clusters, means platform admins have no control over which repositories make up the desired state. When this flag is enabled, all resources must refer to local files included in the source artifact, meaning that only the Flux sources defined in Git can affect the cluster state.