Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix job wait by adding polling options to impersonation client #687

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

somtochiama
Copy link
Member

Fixes: #686

Use polling options (such as the internal custom job statusreaders) when creating a new status poller.

Signed-off-by: Somtochi Onyekwere somtochionyekwere@gmail.com

Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
@stefanprodan stefanprodan changed the title Add polling options to impersonation client Fix job wait by adding polling options to impersonation client Jun 29, 2022
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @somtochiama 🥇

@stefanprodan stefanprodan merged commit 2aa69b6 into fluxcd:main Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Healthcheck on Job ignores job status
2 participants