decryptor: recover from SOPS store panic #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
sops-recover-store-panic
branch
3 times, most recently
from
5aee735
to
4276e37
Compare
|
I have been unable to come up with a test case which actually reproduces the issue, due to not having a clear view of the environment of the user which reported it. But this catches things at the right point for any panic that may occur while working with the SOPS store, which should resolve things based on the stack trace that was shared. |
Merged
Based on user reports, there seems to be a small chance for the underlying SOPS store implementation to panic when a user provides input and/or output format instructions which do not actually match the type of the file. Recover from this to ensure continuity of operations. Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
force-pushed
the
sops-recover-store-panic
branch
from
4276e37
to
2cdc9a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on user reports, there seems to be a small chance for the
underlying SOPS store implementation to panic when a user provides input
and/or output format instructions which do not actually match the type
of the file. Recover from this to ensure continuity of operations.