Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Extract decrytor to internal package #739

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Refactor: Extract decrytor to internal package #739

merged 1 commit into from
Oct 7, 2022

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Oct 6, 2022 •
edited

Move the decryption logic and related unit tests from controllers to internal/decrytor.

Ref: #663

@stefanprodan
Refactor: Extract decrytor to internal package
06ce60f 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan added this to the GA milestone Oct 6, 2022
pjbgf
pjbgf approved these changes Oct 7, 2022
View reviewed changes
Copy link
Member

@pjbgf pjbgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanprodan stefanprodan merged commit 99b2eae into main Oct 7, 2022
@stefanprodan stefanprodan deleted the refactor-decryptor branch October 7, 2022 09:03
@stefanprodan stefanprodan modified the milestones: GA, Bootstrap GA Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjbgf pjbgf pjbgf approved these changes

@hiddeco hiddeco Awaiting requested review from hiddeco

Assignees
No one assigned
Labels
None yet
Projects
Maintainers' Focus
Archived in project
Milestone
Bootstrap GA
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stefanprodan @pjbgf