Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(Provider/Matrix): Load CA from CertSecretRef #318

Merged
merged 1 commit into from Jan 26, 2022

Conversation

Nold360
Copy link
Contributor

@Nold360 Nold360 commented Jan 26, 2022

This PR fixes #316 and allows using custom CA certificates with the Matrix provider.

@stefanprodan
Copy link
Member

@Nold360 can you please signoff your commit, instructions here: https://github.com/fluxcd/notification-controller/pull/318/checks?check_run_id=4949662575

@Nold360
Copy link
Contributor Author

Nold360 commented Jan 26, 2022

@Nold360 can you please signoff your commit, instructions here: https://github.com/fluxcd/notification-controller/pull/318/checks?check_run_id=4949662575

Should be fixed now @stefanprodan

Signed-off-by: nold <nold@gnu.one>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @Nold360 🏅

@stefanprodan stefanprodan changed the title Fix(Provider/Matrix): CertSecretRef Fix(Provider/Matrix): Load CA from CertSecretRef Jan 26, 2022
@stefanprodan stefanprodan merged commit 71f6c62 into fluxcd:main Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Matrix: Can't get CertSecretRef working
2 participants