Allow the proxy address to specified in the Kubernetes Secret from Alert spec.secretRef
#331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
requested changes
Feb 18, 2022
fsequeira1
force-pushed
the
add-proxy-to-secretref
branch
from
9da52ef
to
7b66425
Compare
|
I understand that the proxy setting can be overwritten, but users need to read our source code to figure this out. Please update the docs and remove the proxy from the example YAML. |
Signed-off-by: Filipe Sequeira <filipe@weave.works> Co-authored-by: Stefan Prodan <stefan.prodan@gmail.com>
fsequeira1
force-pushed
the
add-proxy-to-secretref
branch
from
7b66425
to
95cf1a6
Compare
stefanprodan
changed the title
spec.secretRef
stefanprodan
added
area/alerting
stefanprodan
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Filipe Sequeira filipe@weave.works