Fix Alert .spec.eventMetadata behavior

[matheuscscp]

Hi @darkowlzz, @hiddeco and @somtochiama, this fixes the behavior we discussed and updates the documentation. Still need to write tests, but please feel free to give an initial pass 👌

Follow up on #519 (comment), and discussed in #528 (review)

[matheuscscp]

make test is failing locally for me for some reason but I see:

--- PASS: TestAlertReconciler_EventHandler (10.68s)

Does the CI run all the tests?

Also, how can I change the log to warning rather than an error?

[darkowlzz]

make test is failing locally for me for some reason but I see:

Doesn't fail locally for me.

Does the CI run all the tests?

CI just runs make test, refer

notification-controller/.github/workflows/e2e.yaml

Line 53 in 49122b9

run: make test

.

Also, how can I change the log to warning rather than an error?

I don't think we have a warning level. The logger we use prefers verbosity levels over named levels. We do have some custom wrapper for warning level log somewhere, but that doesn't work well with the underlying zap logging levels and results in weird logs.

[matheuscscp]

I don't think we have a warning level. The logger we use prefers verbosity levels over named levels. We do have some custom wrapper for warning level log somewhere, but that doesn't work well with the underlying zap logging levels and results in weird logs.

I see. Should I keep it as is then? (error log)

[darkowlzz]

Should I keep it as is then? (error log)

Looking at the existing usage of error log, I'm more inclined towards an info log as it'd be beneficial if it's readily visible, without the need to change debug levels.

[matheuscscp]

@stefanprodan @darkowlzz we should probably also merge this for rc4?

[hiddeco]

This looks good to me, but requires a rebase.

[stefanprodan]

LGTM

Thanks @matheuscscp