Handle delete before adding finalizer #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
approved these changes
Jul 24, 2023
makkes
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
@darkowlzz Good spotting. Is there a way we can add a regression test for this case?
In Reconcile() methods, move the object deletion above add finalizer. Finalizers can't be set when an object is being deleted. Signed-off-by: Sunny <darkowlzz@protonmail.com>
darkowlzz
force-pushed
the
delete-before-finalize
branch
from
e5c4e6b
to
937da68
Compare
Added a test for it across all the reconcilers. |
makkes
approved these changes
Jul 26, 2023
stefanprodan
added
the
backport:release/v1.0.x
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
Reconcile()methods, move the object deletion above add finalizer. Finalizers can't be set when an object is being deleted.Found by @hiddeco while working on helm-controller. Refer kubernetes-sigs/cluster-api@cef1cf1 .