git/libgit2: add support for ssh proxy and tests #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjbgf
reviewed
Aug 30, 2022
pjbgf
reviewed
Aug 30, 2022
pjbgf
requested changes
Aug 30, 2022
|
Now that SC/IAC have the refactoring changes merges, we should be in a good place to merge this. Please rebase. |
aryan9600
force-pushed
the
proxy
branch
5 times, most recently
from
f8dc1c0
to
d69df5a
Compare
pjbgf
requested changes
Nov 23, 2022
| @@ -31,6 +31,8 @@ replace github.com/go-git/go-billy/v5 => github.com/go-git/go-billy/v5 v5.3.2-0. | |||
| require ( | |||
| github.com/Masterminds/semver/v3 v3.1.1 | |||
| github.com/ProtonMail/go-crypto v0.0.0-20221026131551-cf6655e29de4 | |||
| github.com/armon/go-socks5 v0.0.0-20160902184237-e75332964ef5 | |||
| github.com/elazarl/goproxy v0.0.0-20220529153421-8ea89ba92021 | |||
There was a problem hiding this comment.
github.com/elazarl/goproxy seems unmaintained, but mostly self-contained. It would be good to find an alternative at some point.
Extend the libgit2 ssh transport to support custom proxies in addition to reading env vars Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for specifying custom proxies while using SSH and tests for both HTTP(S) and SSH proxies. It also adds a
ClientOptionto let users configure a proxy for the client.