Prevent panic when cloning empty git repository #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This actually does the right thing but was not taken into account while updating the package, as code doc clearly states:
|
hiddeco
reviewed
Feb 7, 2023
hiddeco
added
bug
relu
force-pushed
the
handle-empty-git-repository
branch
from
b054fbd
to
c8fdc36
Compare
hiddeco
reviewed
Feb 7, 2023
relu
force-pushed
the
handle-empty-git-repository
branch
from
c8fdc36
to
2f69bf0
Compare
darkowlzz
reviewed
Feb 7, 2023
This covers the edge case in which a user creates a GitRepository CR referencing an empty Git repository. Currently, the controller will panic in this situation since the returned commit pointer is nil. Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
relu
force-pushed
the
handle-empty-git-repository
branch
from
2f69bf0
to
14a4a5e
Compare
darkowlzz
approved these changes
Feb 7, 2023
There was a problem hiding this comment.
LGTM!
Thanks.
Based on fluxcd/pkg#393 (comment), if and when the git package is updated, we can update the fix to adapt to it.
hiddeco
approved these changes
Feb 7, 2023
|
i did not just spend 6 hours syncing with the wrong remote 🥲 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers the edge case in which a user creates a GitRepository CR referencing an empty Git repository. Currently, the controller will panic in this situation since the returned commit pointer is nil.