Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Azure Workload Identity #1048

Merged
merged 2 commits into from Mar 30, 2023
Merged

Conversation

somtochiama
Copy link
Member

@somtochiama somtochiama commented Mar 8, 2023

This PR adds support for Azure Workload Identity for OCIRepositories, Buckets and HelmRepositories when using provider: azure.

Complemnets: fluxcd/image-reflector-controller#363

Part of: fluxcd/flux2#3041

@somtochiama somtochiama requested a review from hiddeco March 8, 2023 17:43
go.mod Outdated Show resolved Hide resolved
@somtochiama somtochiama changed the title Upgrade to azidentity v1.3.0-beta.3 to enable Workload Identity Upgrade to azidentity v1.3.0-beta.4 to enable Workload Identity Mar 9, 2023
go.mod Outdated Show resolved Hide resolved
@stefanprodan stefanprodan added the hold Issues and pull requests put on hold label Mar 28, 2023
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PS. This is on hold un till we merge the v1 APIs

@hiddeco
Copy link
Member

hiddeco commented Mar 29, 2023

Given the complexity of documenting this on a second look, we need either need to release this while adding writing extensive documentation for it to the backlog, or leave it out for now.

@hiddeco hiddeco force-pushed the azure-identity branch 2 times, most recently from a59c980 to e4d70f5 Compare March 29, 2023 11:53
@hiddeco hiddeco changed the title Upgrade to azidentity v1.3.0-beta.4 to enable Workload Identity Support Azure Workload Identity Mar 29, 2023
@hiddeco hiddeco added area/helm Helm related issues and pull requests area/bucket Bucket related issues and pull requests area/oci OCI related issues and pull requests enhancement New feature or request labels Mar 29, 2023
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To my understanding this would also require changes for HelmRepository and OCIRepository?

docs/spec/v1beta2/buckets.md Outdated Show resolved Hide resolved
docs/spec/v1beta2/buckets.md Outdated Show resolved Hide resolved
docs/spec/v1beta2/buckets.md Outdated Show resolved Hide resolved
docs/spec/v1beta2/buckets.md Outdated Show resolved Hide resolved
docs/spec/v1beta2/buckets.md Outdated Show resolved Hide resolved
docs/spec/v1beta2/ocirepositories.md Outdated Show resolved Hide resolved
docs/spec/v1beta2/helmrepositories.md Outdated Show resolved Hide resolved
@hiddeco hiddeco force-pushed the azure-identity branch 2 times, most recently from 7905f60 to 67c0f67 Compare March 30, 2023 09:11
@stefanprodan stefanprodan added this to the Bootstrap GA milestone Mar 30, 2023
With an update to github.com/fluxcd/pkg/oci v0.22.0.

This includes a pin of `github.com/docker/docker` to `v20.10.x`, to
prevent Oras from complaining.

Co-authored-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
Co-authored-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
@stefanprodan stefanprodan removed the hold Issues and pull requests put on hold label Mar 30, 2023
@hiddeco hiddeco merged commit 288d079 into fluxcd:main Mar 30, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bucket Bucket related issues and pull requests area/helm Helm related issues and pull requests area/oci OCI related issues and pull requests enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants