Add the verification key to the GitRepository verified status condition #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the ID of the key that was successful to the verified status for GitRepository resources. Signed-off-by: Kevin McDermott <kevin@weave.works>
stefanprodan
changed the title
stefanprodan
approved these changes
Jun 28, 2023
There was a problem hiding this comment.
LGTM
This is a great improvement to observability. If users collect the Flux events, they can determine which person signed the changeset by matching the key ID to a person's GH/GL user.
Thanks @bigkevmcd 🏅
hiddeco
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ID of the key that was successful to the verified status for GitRepository resources.