Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GHA backport.yaml workflow job perms #1156

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

relu
Copy link
Member

@relu relu commented Jul 6, 2023

Fixing backport workflow permissions.

Fixing backport workflow permissions.

Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
@relu relu requested a review from stefanprodan July 6, 2023 07:27
@relu relu added the area/ci CI related issues and pull requests label Jul 6, 2023
@hiddeco
Copy link
Member

hiddeco commented Jul 6, 2023

Think we should also include the echo -E fix in release.yaml to prevent any newlines from messing up the release process in the future. Reference here: fluxcd/flux2#4041

@hiddeco hiddeco added the backport:release/v1.0.x To be backported to release/v1.0.x label Jul 6, 2023
Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
@stefanprodan stefanprodan merged commit 6700ac1 into main Jul 6, 2023
10 checks passed
@stefanprodan stefanprodan deleted the gha-backport-workflow-perms branch July 6, 2023 08:53
@fluxcdbot
Copy link
Member

Backport failed for release/v1.0.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release/v1.0.x
git worktree add -d .worktree/backport-1156-to-release/v1.0.x origin/release/v1.0.x
cd .worktree/backport-1156-to-release/v1.0.x
git checkout -b backport-1156-to-release/v1.0.x
ancref=$(git merge-base 31101f04c33db8a4f77664c6a1c5bfd727fb814d 680843fd698cd78f4834f8e50e93f220bd7d7935)
git cherry-pick -x $ancref..680843fd698cd78f4834f8e50e93f220bd7d7935

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci CI related issues and pull requests backport:release/v1.0.x To be backported to release/v1.0.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants