Update docs on Azure identity #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -233,6 +233,12 @@ by extension gain access to ACR. | |||
| When the kubelet managed identity has access to ACR, source-controller running on | |||
| it will also have access to ACR. | |||
|
|
|||
| *Note*: If you have more identity configured on the cluster, you have to specify which one to use | |||
There was a problem hiding this comment.
Suggested change
| *Note*: If you have more identity configured on the cluster, you have to specify which one to use | |
| *Note*: If you have more than one identity configured on the cluster, you have to specify which one to use |
| To use Workload Identity, you have to install the Workload Identity | ||
| mutating webhook and create an identity that has access to ACR. Next, establish | ||
| To use Workload Identity, the Workload Identity mutating webhook has to be installed on your cluster and | ||
| you have tocreate an identity that has access to ACR. Next, establish |
There was a problem hiding this comment.
Suggested change
| you have tocreate an identity that has access to ACR. Next, establish | |
| you have to create an identity that has access to ACR. Next, establish |
hiddeco
reviewed
Jul 14, 2023
| @@ -224,7 +224,7 @@ to the IAM role when using IRSA. | |||
|
|
|||
| #### Azure | |||
|
|
|||
| The `azure` provider can be used to authenticate automatically using kubelet managed | |||
| The `azure` provider can be used to authenticate automatically using workload identity, kubelet managed | |||
There was a problem hiding this comment.
Suggested change
| The `azure` provider can be used to authenticate automatically using workload identity, kubelet managed | |
| The `azure` provider can be used to authenticate automatically using Workload Identity, kubelet managed |
| a federated identity between the source-controller ServiceAccount and the | ||
| identity. Patch the source-controller Pod and ServiceAccount as shown in the patch | ||
| above. Please take a look at this [guide](https://azure.github.io/azure-workload-identity/docs/quick-start.html#6-establish-federated-identity-credential-between-the-identity-and-the-service-account-issuer--subject). | ||
|
|
||
| ##### AAD Pod Identity | ||
| ##### AAD Pod Identity - Deprecated! |
There was a problem hiding this comment.
Suggested change
| ##### AAD Pod Identity - Deprecated! | |
| ##### Deprecated: AAD Pod Identity |
darkowlzz
reviewed
Jul 17, 2023
|
Also, these changes would apply to OCIRepository and Bucket spec docs too. |
darkowlzz
reviewed
Jul 19, 2023
darkowlzz
approved these changes
Jul 21, 2023
| ##### AAD Pod Identity | ||
| ##### Deprecated: AAD Pod Identity | ||
|
|
||
| **Note:** The AAD Pod Identity project will be archived in [September 2023](https://github.com/Azure/aad-pod-identity#-announcement), |
There was a problem hiding this comment.
Should we have warnings instead of notes for deprecation?
There was a problem hiding this comment.
We can follow the docs style guide
https://fluxcd.io/contributing/docs/style-guide/#warning
There was a problem hiding this comment.
Since these docs are used in the docs site, it may be better to use all the shortcodes. But then that'll not be a standard markdown document and I think at present, the spec docs are just standard markdown documents.
We may have to collectively decide what to do about it and update all the docs to use the shortcodes if we go with the docs style guide.
There was a problem hiding this comment.
I have changed it to use markdown with Warning instead
stefanprodan
approved these changes
Aug 1, 2023
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
somtochiama
force-pushed
the
azure-docs
branch
from
6b80284
to
fb2c74d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.