Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bitnami MInio oci chart for e2e #1301

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

somtochiama
Copy link
Member

This pull request uses the Bitnami Minio oci chart for e2e and fixes the failing pipeline: https://github.com/fluxcd/source-controller/actions/runs/7045945128/job/19176700925

@somtochiama somtochiama marked this pull request as draft November 30, 2023 13:00
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the MC_RELEASE and SHAs to match the 2023.11.20 release.

hack/ci/e2e.sh Outdated Show resolved Hide resolved
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
@somtochiama somtochiama marked this pull request as ready for review November 30, 2023 13:36
--version "${MINIO_HELM_VER}" \
--timeout 10m0s \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusted timeout due to error in pipeline. Pipeline passing now with new timeout

Release "minio" does not exist. Installing it now.
Pulled: registry-1.docker.io/bitnamicharts/minio:12.10.3
Digest: sha256:530b2db8981088ab479a4503fa88e211f6808038f6b0177e4715d3d44f7510b2
Error: timed out waiting for the condition

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @somtochiama 🏅

@stefanprodan stefanprodan merged commit 41c44b7 into fluxcd:main Nov 30, 2023
10 checks passed
@stefanprodan stefanprodan added the area/testing Testing related issues and pull requests label Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Testing related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants