Rely on index checksum for HelmRepository reconcile operation #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
reviewed
Jan 23, 2021
martinezleoml
force-pushed
the
FIX/helm-repository-unchanged-index
branch
from
4dca0c7
to
9ee6f68
Compare
hiddeco
reviewed
Jan 25, 2021
martinezleoml
force-pushed
the
FIX/helm-repository-unchanged-index
branch
from
9ee6f68
to
0440a5c
Compare
|
Should be ready to merge, sorry for all the back and forth. ;) |
hiddeco
reviewed
Jan 25, 2021
| @@ -209,11 +209,16 @@ func (r *HelmRepositoryReconciler) reconcile(ctx context.Context, repository sou | |||
| return sourcev1.HelmRepositoryNotReady(repository, sourcev1.IndexationFailedReason, err.Error()), err | |||
| } | |||
|
|
|||
| // return early on unchanged generation | |||
| indexBytes, err := yaml.Marshal(chartRepo.Index) | |||
There was a problem hiding this comment.
Suggested change
| indexBytes, err := yaml.Marshal(chartRepo.Index) | |
| indexBytes, err := yaml.Marshal(&chartRepo.Index) |
This will be the last requested change, promised 🖐️
There was a problem hiding this comment.
Good catch, here we go!
hiddeco
added
area/helm
Fixes fluxcd#256 Signed-off-by: Léo Martinez <leo84.martinez@gmail.com>
martinezleoml
force-pushed
the
FIX/helm-repository-unchanged-index
branch
from
0440a5c
to
c1512d3
Compare
hiddeco
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #256