Fix chart with custom valuesFile (0bytes tgz)

[raffis]

Creating a HelmRelease/Chart with a valuesFile declaration ends with a 0bytes tgz on the storage path.

$ ls -l /tmp/storage/helmchart/flux-system/podinfo
total 0
-rw-r--r--  1 raffis  wheel   0 Feb  9 09:48 podinfo-5.1.4.tgz
-rw-r--r--  1 raffis  wheel   0 Feb  9 09:48 podinfo-5.1.4.tgz.lock
lrwxr-xr-x  1 raffis  wheel  60 Feb  9 09:48 podinfo-latest.tgz -> /tmp/storage/helmchart/flux-system/podinfo/podinfo-5.1.4.tgz

Reproducing manifests:

apiVersion: source.toolkit.fluxcd.io/v1beta1
kind: HelmRepository
metadata:
  name: podinfo
  namespace: flux-system
spec:
  interval: 5m
  url: https://stefanprodan.github.io/podinfo
---
apiVersion: source.toolkit.fluxcd.io/v1beta1
kind: HelmChart
metadata:
  name: podinfo
  namespace: flux-system
spec:
  interval: 1m
  sourceRef:
    kind: HelmRepository
    name: podinfo
  chart: podinfo
  valuesFile: values-prod.yaml

The problem is that the it falls through to default as well and executes the atomicwrite as well.
This pr fixes that behavior.

Two other hints:

• Might need to add a test to validate the written tgz
• The Copy() method in the storage package is quite the same as AtomicWriteFile(), only difference is the chmod, might merge these two as in either case the mode can be set I reckon.

[relu]

I think just adding a break statement here would solve the problem. The idea of the default block fallthrough was to prevent duplication.

[raffis]

Yeah thats fine as well, I've changed it to just having a break here.

[relu]

Nice catch, @raffis! 🎣

I can definitely see the problem. I added a comment about the proposed solution with the hope that we can prevent the introduced duplication of the package writing logic block.

[relu]

LGTM ✔️

Thank you, @raffis!

[relu]

Regarding your note about Copy() and AtomicWriteFile(), I think it does make sense to extract the common part or merge the two. Feel free to submit a PR if you want to work on that, it would be much appreciated.