Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SSH private key with password #338

Merged
merged 2 commits into from
Apr 12, 2021
Merged

Support SSH private key with password #338

merged 2 commits into from
Apr 12, 2021

Conversation

somtochiama
Copy link
Member

This pull request uses password from secret in the publicKeyAuth Method

Signed-off-by: Somtochi Onyekwere somtochionyekwere@gmail.com

@somtochiama
Use password in git method for secret
e82c8e8 
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
@somtochiama somtochiama marked this pull request as draft April 12, 2021 14:53
hiddeco
hiddeco reviewed Apr 12, 2021
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only nitpicks, other than that 🏅

pkg/git/gogit/transport_test.go Show resolved Hide resolved
pkg/git/gogit/transport.go Outdated Show resolved Hide resolved
@hiddeco hiddeco changed the title Use password in git method for secret Support SSH private key with password Apr 12, 2021
@hiddeco hiddeco added area/git Git related issues and pull requests enhancement New feature or request labels Apr 12, 2021
@somtochiama
Add tests for libgit2
d3d1917 
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
@somtochiama somtochiama marked this pull request as ready for review April 12, 2021 15:33
hiddeco
hiddeco approved these changes Apr 12, 2021
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @somtochiama 🌻

@hiddeco hiddeco merged commit 0693289 into fluxcd:main Apr 12, 2021
@hiddeco hiddeco mentioned this pull request Apr 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
area/git Git related issues and pull requests enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@somtochiama @hiddeco