Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Helm to v3.6.3 #400

Merged
merged 1 commit into from Jul 15, 2021
Merged

Update Helm to v3.6.3 #400

merged 1 commit into from Jul 15, 2021

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Jul 14, 2021

No description provided.

@hiddeco
Update Helm to v3.6.3
5e8e0ab 
Signed-off-by: Hidde Beydals <hello@hidde.co>
@hiddeco hiddeco added area/helm Helm related issues and pull requests area/ci CI related issues and pull requests labels Jul 14, 2021
@squaremo
Copy link
Member

Is this a routine bump or does it fix something?

@hiddeco
Copy link
Member Author

hiddeco commented Jul 15, 2021 •
edited

It is a routine bump, but does include a patch to properly set the managedFields as managed by Helm.

squaremo
squaremo approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me 🍏 Perhaps we should have a practice of mentioning the reason for a patch bump in the commit message, even if it's just for the purpose of keeping up.

@hiddeco
Copy link
Member Author

hiddeco commented Jul 15, 2021

Perhaps we should have a practice of mentioning the reason for a patch bump in the commit message, even if it's just for the purpose of keeping up.

I have a practice of mentioning things that a patch specifically fixes if they are relevant, otherwise it can assumed to be a routine patch.

@hiddeco hiddeco merged commit 40a4767 into main Jul 15, 2021
@hiddeco hiddeco deleted the update-deps branch July 15, 2021 09:10
@squaremo
Copy link
Member

I have a practice of mentioning things that a patch specifically fixes if they are relevant, otherwise it can assumed to be a routine patch.

I believe it :-) I was just thinking if we all get into the habit of at least saying "Routine bump" then no-one will need to wonder if there's some specific fix involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squaremo squaremo squaremo approved these changes

@phillebaba phillebaba Awaiting requested review from phillebaba

@relu relu Awaiting requested review from relu

Assignees
No one assigned
Labels
area/ci CI related issues and pull requests area/helm Helm related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hiddeco @squaremo