Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

controllers: Git checkout strategies and in-memory known hosts db #52

Merged
merged 6 commits into from
May 3, 2020
Merged

controllers: Git checkout strategies and in-memory known hosts db #52

merged 6 commits into from
May 3, 2020

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented May 2, 2020 •
edited
Loading

  • factor out GitRepository verification
  • use in-memory known hosts database
  • factor out checkout into strategies per ref type
  • drop openssh-client dep from Docker image

@hiddeco hiddeco force-pushed the git-improvements branch 6 times, most recently from 3a9fe5a to a0d4e44 Compare May 3, 2020 08:02
stefanprodan
stefanprodan approved these changes May 3, 2020
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏅

internal/git/checkout.go Outdated Show resolved Hide resolved
@hiddeco hiddeco added area/git Git related issues and pull requests enhancement New feature or request labels May 3, 2020
@hiddeco hiddeco changed the title GitRepository improvements controllers: Git checkout strategies and in-memory known hosts db May 3, 2020
@hiddeco hiddeco marked this pull request as ready for review May 3, 2020 21:38
@hiddeco hiddeco merged commit 0354d8d into master May 3, 2020
@hiddeco hiddeco deleted the git-improvements branch May 3, 2020 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
area/git Git related issues and pull requests enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hiddeco @stefanprodan