Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/git: Include commit message and URL in checkout error #579

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

darkowlzz
Copy link
Contributor

go-git: Include the commit message in the returned commit object.
libgit2: Set the URL in the checkout error.

@hiddeco hiddeco added the area/git Git related issues and pull requests label Feb 14, 2022
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @darkowlzz 🙇

@hiddeco hiddeco added the bug Something isn't working label Feb 14, 2022
@darkowlzz
Copy link
Contributor Author

I'll update the associated test failure seen in https://github.com/fluxcd/source-controller/runs/5185701765?check_suite_focus=true#step:6:225
and also add a method in the commit object to provide a short message to use it in notifications.

@darkowlzz darkowlzz force-pushed the git-commit-msg-url branch 3 times, most recently from bbab63a to d049f19 Compare February 14, 2022 16:04
go-git: Include the commit message in the returned commit object.
libgit2: Set the URL in the checkout error.

Add new method Commit.ShortMessage() for returning short commit
message.

Signed-off-by: Sunny <darkowlzz@protonmail.com>
@darkowlzz darkowlzz merged commit 69ae21b into main Feb 14, 2022
@darkowlzz darkowlzz deleted the git-commit-msg-url branch February 14, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/git Git related issues and pull requests bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants