Experimental managed transport for libgit2 operations #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So far manual tests seem to be working as expected. Tests used github for SSH and auth-less HTTPS, and Azure DevOps for HTTPS with basic auth. |
pjbgf
force-pushed
the
managed-transport-libgit130
branch
from
ddf5af9
to
dec736e
Compare
pjbgf
changed the title
|
Happy with the direction this is headed at for experimental introduction. Couple of things I would like to see:
On an additional note, and as already mentioned on Slack. The introduction of this opens up the discussion if we do want to leverage the same trick for |
hiddeco
changed the title
hiddeco
added
enhancement
pjbgf
force-pushed
the
managed-transport-libgit130
branch
4 times, most recently
from
82d1638
to
229b116
Compare
pjbgf
force-pushed
the
managed-transport-libgit130
branch
from
229b116
to
31e28bf
Compare
hiddeco
reviewed
Mar 14, 2022
pjbgf
force-pushed
the
managed-transport-libgit130
branch
2 times, most recently
from
bf6cb1c
to
e98bd36
Compare
libgit2 network operations are blocking and do not provide timeout nor context capabilities, leading for several reports by users of the controllers hanging indefinitely. By using managed transport, golang primitives such as http.Transport and net.Dial can be used to ensure timeouts are enforced. Co-Authored-by: Sunny <darkowlzz@protonmail.com> Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
The initial implementation was based off upstream, which cause an initial request to fail, and only then the credentials would be added into the request. Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
For backwards compatibility, support for HTTP redirection is enabled when targeting the same host, and no TLS downgrade took place. Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
darkowlzz
force-pushed
the
managed-transport-libgit130
branch
from
c841a07
to
115040e
Compare
darkowlzz
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libgit2network operations are blocking and do not provide timeout nor context capabilities, leading to users reporting that source-controller can hang indefinitely.By using managed transport, golang primitives such as http.Transport and net.Dial can be used to ensure timeouts are enforced.
This will initially be guarded behind a feature switch via environment variable
EXPERIMENTAL_GIT_TRANSPORT.Fixes: #402
This has been also tested against IAC and should fix fluxcd/image-automation-controller#286 and fluxcd/image-automation-controller#282. The tested were based off fluxcd/image-automation-controller#325 - thanks @darkowlzz.
This work should be followed-up by fluxcd/pkg#245, to consolidate the git implementation code and have it extracted away from the controllers.