Add notify() in all the reconcilers #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkowlzz
force-pushed
the
recovery-event
branch
3 times, most recently
from
e842cf7
to
ef6d576
Compare
darkowlzz
force-pushed
the
recovery-event
branch
from
ef6d576
to
7cbdcf2
Compare
darkowlzz
force-pushed
the
recovery-event
branch
from
7cbdcf2
to
ee8e33d
Compare
darkowlzz
force-pushed
the
recovery-event
branch
from
ee8e33d
to
2a910cb
Compare
hiddeco
reviewed
Apr 7, 2022
darkowlzz
force-pushed
the
recovery-event
branch
from
2a910cb
to
f81a617
Compare
stefanprodan
approved these changes
Apr 7, 2022
darkowlzz
force-pushed
the
recovery-event
branch
from
f81a617
to
052b65a
Compare
darkowlzz
commented
Apr 7, 2022
notify() is used to emit events for new artifact and failure recovery scenarios. It's implemented in all the reconcilers. Previously, when there used to be a failure due to any reason, on a subsequent successful reconciliation, no notification was sent to indicate that the failure has been resolved. With notify(), the old version of the object is compared with the new version of the object to determine if all, if any, of the failures have been resolved and a notification is sent. The notification message is the same that's sent in usual successful source reconciliation message about stored artifact. Signed-off-by: Sunny <darkowlzz@protonmail.com>
darkowlzz
force-pushed
the
recovery-event
branch
from
052b65a
to
5da74ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
notify()is used to emit events for new artifact and failure recoveryscenarios. It's implemented in all the reconcilers.
Previously, when there used to be a failure due to any reason, on a
subsequent successful reconciliation, no notification was sent to
indicate that the failure has been resolved.
With notify(), the old version of the object is compared with the new
version of the object to determine that all, if any, of the failures have
been resolved and a notification is sent. The notification message is
the same that's sent in usual successful source reconciliation message
about stored artifact.
Failure and immediate success notification looks like the following in
case of GitRepo:
Similarly, for bucket, if the credentials are deleted for an existing bucket
and added back: