libgit2: recover from git2go panic #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some specific scenarios may lead libgit2 or git2go to panic. Adding a recovery logic, ensures a predictable execution path for callers, and safeguards the controller's stability. Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
|
Failing tests are orthogonal to the changes. 👀 |
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
stefanprodan
approved these changes
May 6, 2022
There was a problem hiding this comment.
LGTM
IMO a controller should never panic as it would impact all tenants, great improvement!
Thanks @pjbgf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some specific scenarios may lead
libgit2orgit2goto panic.Adding a recovery logic, ensures a predictable execution path for callers, and safeguards the controller's stability.
xref: fluxcd/flux2#2593