libgit2: enable managed transport by default

[pjbgf]

GitManagedTransport is a new feature gate that enables the use of Managed Transport.
This replaces the previous EXPERIMENTAL_GIT_TRANSPORT environment variable that was used for the same result.

This is now an opt-out feature, which can be disabled by starting the controller with the argument --feature-gates=GitManagedTransport=false.

Fixes #689

[stefanprodan]

@pjbgf can you confirm this was tested with Azure DevOps and AWS CodeCommit?

[pjbgf]

@pjbgf can you confirm this was tested with Azure DevOps and AWS CodeCommit?

This has been tested against:

NAME                            REVISION                                        SUSPENDED       READY   MESSAGE                                                                              
https-bitbucket                 main/d35781a                                    False           True    stored artifact for revision 'main/d35781accf1ea8078de18e154622486042bca4cc'         
https-devops                    main/f0958a4                                    False           True    stored artifact for revision 'main/f0958a4a6f09fe0f893ade2087223755e53661a6'         
https-gitlab                    main/0ee437c                                    False           True    stored artifact for revision 'main/0ee437c33f499e2f588f60e6a92a547f6d5845f8'         
ssh-ecdsa-bitbucket             main/d35781a                                    False           True    stored artifact for revision 'main/d35781accf1ea8078de18e154622486042bca4cc'         
ssh-ecdsa-gitlab                main/0ee437c                                    False           True    stored artifact for revision 'main/0ee437c33f499e2f588f60e6a92a547f6d5845f8'         
ssh-ed25519-bitbucket           main/d35781a                                    False           True    stored artifact for revision 'main/d35781accf1ea8078de18e154622486042bca4cc'         
ssh-rsa-bitbucket               main/d35781a                                    False           True    stored artifact for revision 'main/d35781accf1ea8078de18e154622486042bca4cc'         
ssh-rsa-devops                  main/f0958a4                                    False           True    stored artifact for revision 'main/f0958a4a6f09fe0f893ade2087223755e53661a6'         
ssh-rsa-gitlab                  main/0ee437c                                    False           True    stored artifact for revision 'main/0ee437c33f499e2f588f60e6a92a547f6d5845f8' 
ssh-rsa-github                  main/989fec7                                    False           True    stored artifact for revision 'main/989fec7acb5a9a5ac33ce0276e09d9d87bed7589'         

@stefanprodan is there any specific thing about AWS CodeCommit we are keen to test it against? Any specific protocol/algo?

[stefanprodan]

We need to make sure we don’t break the recommendations made in our AWS docs https://fluxcd.io/docs/use-cases/aws-codecommit/

[pjbgf]

Trying to use our documentation did not work for me. By going through the official AWS CodeCommit docs, it seems we are missing Your-SSH-Key-ID@ for the SSH URLs.

Once that was sorted, the reconciliation only worked fine when this changes were applied in addition to the changes on #713.

flux reconcile source git ssh-rsa-aws-codecommit
► annotating GitRepository ssh-rsa-aws-codecommit in flux-system namespace
✔ GitRepository annotated
◎ waiting for GitRepository reconciliation
✔ fetched revision main/9686c1a4d6038f3df4a96d453cd809c1d4085bc7

Will put this on hold until the other PR is merged.

[pjbgf]

Re-adding hold, until changes from branch gitrepo-rec-fixes gets merged.

[stefanprodan]

LGTM

Thanks @pjbgf 🏅