Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log when the OCI temp credentials file can't be deleted #726

Merged
merged 2 commits into from
May 24, 2022

Conversation

makkes
Copy link
Member

@makkes makkes commented May 23, 2022

depends on #725

@makkes makkes mentioned this pull request May 23, 2022
6 tasks
@makkes makkes self-assigned this May 23, 2022
@makkes makkes added the area/helm Helm related issues and pull requests label May 23, 2022
@pjbgf pjbgf added this to the GA milestone May 23, 2022
@makkes makkes requested a review from darkowlzz May 23, 2022 14:49
@makkes makkes force-pushed the oci-improvements branch 2 times, most recently from dc218a3 to 1eaf0a3 Compare May 23, 2022 14:50
@makkes makkes requested a review from darkowlzz May 23, 2022 15:33
@makkes makkes added the area/oci OCI related issues and pull requests label May 23, 2022
Base automatically changed from oci-dockerconfig to main May 24, 2022 09:37
@makkes makkes force-pushed the oci-improvements branch 2 times, most recently from 3e3f073 to 5cadd3a Compare May 24, 2022 11:47
Max Jonas Werner added 2 commits May 24, 2022 15:06
Signed-off-by: Max Jonas Werner <mail@makk.es>
Signed-off-by: Max Jonas Werner <mail@makk.es>
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@makkes makkes merged commit 55a594a into main May 24, 2022
@makkes makkes deleted the oci-improvements branch May 24, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Helm related issues and pull requests area/oci OCI related issues and pull requests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants