Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libgit2: fix ssh host key verification regression #771

Merged
merged 1 commit into from
Jun 8, 2022

Commits on Jun 8, 2022

  1. libgit2: fix ssh host key verification regression

    Earlier, host key verification could potentially fail if there were
    multiple entries in the known_hosts file and if the intended encryption
    algorithm wasn't the first entry. This happened because we used the same
    hasher object to compute the sum of all the public keys present in the
    known_hosts file, which led to invalid hashes, resulting in a mismatch
    when compared with the hash of the advertised public key. This is fixed,
    by not creating the hasher ourselves and instead delegating that to the
    function actually doing the matching, ensuring that a new hasher is used
    for each comparison.
    
    Regression introduced in v0.25.0 and reported in
    fluxcd/image-automation-controller#378
    
    Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
    aryan9600 committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    4769253 View commit details
    Browse the repository at this point in the history