libgit2: improve known_hosts error messages #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryan9600
requested changes
Jun 14, 2022
darkowlzz
reviewed
Jun 14, 2022
| knownHosts: []byte(knownHostsFixtureUnormalized), | ||
| hostkey: git2go.HostkeyCertificate{Kind: git2go.HostkeySHA256, HashSHA256: sha256Fingerprint("AGvEpqYNMqsRNIviwyk4J4HM0lEylomDBKOWZsBn434")}, | ||
| expectedHost: "source.developers.google.com:2022", | ||
| want: fmt.Errorf("no entries in known_hosts matches host '[source.developers.google.com]:2022' with fingerprint 'AGvEpqYNMqsRNIviwyk4J4HM0lEylomDBKOWZsBn434='"), |
There was a problem hiding this comment.
Pointing this out just to highlight how this looks like when printing the fingerprint in the error, so that we can discuss and think if there's a better way to express this error.
There was a problem hiding this comment.
This is what it looks like in the GitRepo object status:
status:
conditions:
- lastTransitionTime: "2022-06-14T15:42:46Z"
message: no artifact for resource in storage
observedGeneration: 1
reason: NoArtifact
status: "True"
type: Reconciling
- lastTransitionTime: "2022-06-14T15:42:47Z"
message: 'failed to checkout and determine revision: unable to fetch-connect to
remote ''ssh://git@example.com:2224/foo/bar.git'':
ssh: handshake failed: no entries in known_hosts matches host ''[example.com]:2224''
with fingerprint ''AGvEpqYNMqsRNIviwyk4J4HM0lEylomDBKOWZsBn434='''
observedGeneration: 1
reason: GitOperationFailed
status: "False"
type: Ready
- lastTransitionTime: "2022-06-14T15:42:47Z"
message: 'failed to checkout and determine revision: unable to fetch-connect to
remote ''ssh://git@example.com:2224/foo/bar.git'':
ssh: handshake failed: no entries in known_hosts matches host ''[example.com]:2224''
with fingerprint ''AGvEpqYNMqsRNIviwyk4J4HM0lEylomDBKOWZsBn434='''
observedGeneration: 1
reason: GitOperationFailed
status: "True"
type: FetchFailed
There was a problem hiding this comment.
Small point here, based on @aryan9600's suggestion, we will no longer add padding to the fingerprints.
aryan9600
reviewed
Jun 14, 2022
aryan9600
requested changes
Jun 15, 2022
darkowlzz
reviewed
Jun 15, 2022
pjbgf
force-pushed
the
known_hosts_error
branch
2 times, most recently
from
1addcd0
to
494bfc2
Compare
darkowlzz
reviewed
Jun 16, 2022
Known hosts can be a difficult problem to troubleshoot. To make it easier for end users, the generic message has now been changed with a much more user friendly one. Now if a known_host is not set, an error message will be returned, instead of it simply being ignored. Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
darkowlzz
force-pushed
the
known_hosts_error
branch
from
494bfc2
to
b490a6a
Compare
|
Rebased. |
darkowlzz
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Known hosts can be a difficult problem to troubleshoot.
To make it easier for end users, the generic message has
now been changed with a much more user friendly one.
Now if a known_host is not set, an error message will be
returned, instead of it simply being ignored.