Fix SIGSEGV when resolving charts dependencies #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
reviewed
Jul 13, 2022
Comment on lines
262
to
265
| supported := repository.IsDepSupported(nUrl) | ||
| if !supported { | ||
| err = fmt.Errorf("unsupported chart repository URL: %s", nUrl) | ||
| return | ||
| } |
There was a problem hiding this comment.
Can we provide a better reason here by making IsDepSupported return e.g. a descriptive error? I think this will reduce support questions by explicitly telling the user it's due to an alias.
hiddeco
reviewed
Jul 13, 2022
hiddeco
reviewed
Jul 13, 2022
If implemented, this make sure than we clear only referenced downloaders. It is also checked if the repository url is supported. Signed-off-by: Soule BA <soule@weave.works>
hiddeco
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #815
If implemented, this make sure that we clear only referenced downloaders.
It is also checked if the repository url is supported.
Signed-off-by: Soule BA soule@weave.works