Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for charts from OCI registries to specify a chart path #856

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

makkes
Copy link
Member

@makkes makkes commented Aug 3, 2022

This change allows for a HelmRepository to point to e.g. "ghcr.io" and
then a HelmRelease pointing to the chart "stefanprodan/charts/podinfo"
in its .spec.chart.spec.chart field.

Related discussion: fluxcd/flux2#2959

@makkes makkes self-assigned this Aug 3, 2022
@makkes makkes added area/helm Helm related issues and pull requests area/oci OCI related issues and pull requests labels Aug 3, 2022
internal/helm/chart/builder.go Outdated Show resolved Hide resolved
internal/helm/chart/builder_test.go Show resolved Hide resolved
@makkes makkes force-pushed the oci-chart-path branch 2 times, most recently from b78cca0 to d18c34d Compare August 8, 2022 13:31
@makkes makkes requested a review from pjbgf August 8, 2022 13:31
Copy link
Member

@pjbgf pjbgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thanks @makkes 🙇

This change allows for a HelmRepository to point to e.g. "ghcr.io" and
then a HelmRelease pointing to the chart "stefanprodan/charts/podinfo"
in its `.spec.chart.spec.chart` field.

Related discussion: fluxcd/flux2#2959

Signed-off-by: Max Jonas Werner <max@e13.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Helm related issues and pull requests area/oci OCI related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants