Handle nil OCI authenticator with malformed registry #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be possible to add a regression test? |
Fixes fluxcd#896 Signed-off-by: Adrien Fillon <adrien.fillon@manomano.com>
adrien-f
force-pushed
the
panic-oci-auth
branch
from
9a0e5bb
to
03ba63b
Compare
|
Sure thing, I've actually moved the change from |
makkes
approved these changes
Sep 14, 2022
makkes
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #896
Signed-off-by: Adrien Fillon adrien.fillon@manomano.com