minio: use container image for tests #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
added
area/ci
hiddeco
force-pushed
the
test-minio-container-img
branch
from
bac670f
to
a5c844f
Compare
This drops the usage of `play.min.io` in favor of running a local container image for tests. Which is a better practice, and resolves test flakiness due to the endpoint being unavailable once in awhile. Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
force-pushed
the
test-minio-container-img
branch
from
a5c844f
to
57543ae
Compare
stefanprodan
approved these changes
Dec 14, 2022
hiddeco
force-pushed
the
test-minio-container-img
branch
4 times, most recently
from
0469348
to
cef8a78
Compare
Ref: https://github.com/abiosoft/colima/blob/main/docs/FAQ.md#cannot-connect-to-the-docker-daemon-at-unixvarrundockersock-is-the-docker-daemon-running Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
force-pushed
the
test-minio-container-img
branch
from
cef8a78
to
2af9541
Compare
pjbgf
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops the usage of
play.min.ioin favor of running a local container image for tests. Which is a better practice, and resolves test flakiness due to the endpoint being unavailable once in awhile.