storage: take lock files into consideration while garbage collecting #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
reviewed
Dec 20, 2022
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
hiddeco
added
bug
hiddeco
reviewed
Dec 20, 2022
| @@ -135,7 +135,7 @@ func main() { | |||
| flag.StringSliceVar(&git.HostKeyAlgos, "ssh-hostkey-algos", []string{}, | |||
| "The list of hostkey algorithms to use for ssh connections, arranged from most preferred to the least.") | |||
| flag.DurationVar(&artifactRetentionTTL, "artifact-retention-ttl", 60*time.Second, | |||
| "The duration of time that artifacts will be kept in storage before being garbage collected.") | |||
| "The duration of time that artifacts from previous reconcilations will be kept in storage before being garbage collected.") | |||
There was a problem hiding this comment.
Think this requires updating of the flag documentation on the website.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sanskar Jaiswal jaiswalsanskar078@gmail.com