Make secret ref configurable #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moolen
force-pushed
the
fix/make-secret-configurable
branch
from
bd960b7
to
acbd7d4
Compare
phillebaba
previously approved these changes
Mar 13, 2021
moolen
force-pushed
the
fix/make-secret-configurable
branch
from
acbd7d4
to
aa2f8e0
Compare
Signed-off-by: Moritz Johner <beller.moritz@googlemail.com>
moolen
force-pushed
the
fix/make-secret-configurable
branch
from
aa2f8e0
to
5170443
Compare
|
There's an outage with github actions right now link. I'll check back tomorrow to see if i need to re-trigger ci |
Signed-off-by: Moritz Johner <beller.moritz@googlemail.com>
moolen
force-pushed
the
fix/make-secret-configurable
branch
from
19a54ec
to
97307f1
Compare
phillebaba
approved these changes
Mar 16, 2021
phillebaba
changed the title
phillebaba
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
GitRepsository.spec.secretRefconfigurable and ensures that the provider stays backwards compatible with the versions pre v0.0.13.In 0.0.13 the default secret-name is
flux-system, before that it was the flux_sync resource name. Details in #104.Closes #104