Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo #522

Merged
merged 1 commit into from Jul 20, 2023
Merged

Fix typo #522

merged 1 commit into from Jul 20, 2023

Conversation

mcklyde
Copy link
Contributor

@mcklyde mcklyde commented Jul 14, 2023 •
edited

Fix typo from psuh to push

@darkowlzz
Copy link
Contributor

Thanks for the fix. Can you please sign your commit. See https://github.com/fluxcd/terraform-provider-flux/pull/522/checks?check_run_id=15033032968 for instructions.

@darkowlzz darkowlzz added area/docs Documentation related issues and pull requests enhancement New feature or request and removed area/docs Documentation related issues and pull requests labels Jul 14, 2023
@mcklyde
Copy link
Contributor Author

mcklyde commented Jul 14, 2023

I've rebased and the commit is now verified. Thanks!

@darkowlzz
Copy link
Contributor

I've rebased and the commit is now verified. Thanks!

Sorry but we need a sign-off in every commit we accept. Commit verification signing is optional. As described in https://github.com/fluxcd/terraform-provider-flux/pull/522/checks?check_run_id=15033032968 you can commit with git commit -s or amend the existing commit with git commit --amend -s and that'll add the sign-off in the commit.

@mcklyde mcklyde force-pushed the mcklyde/fix-typo branch 2 times, most recently from d10817e to 6833af2 Compare July 17, 2023 20:54
@mcklyde @darkowlzz
Fix typo
8a3c438 
Signed-off-by: McKlyde <hello@mcklyde.com>
darkowlzz
darkowlzz approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@darkowlzz darkowlzz merged commit 2137950 into fluxcd:main Jul 20, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkowlzz darkowlzz darkowlzz approved these changes

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mcklyde @darkowlzz @stefanprodan